https://bugzilla.redhat.com/show_bug.cgi?id=1991145 Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jkadlcik@xxxxxxxxxx --- Comment #7 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Hello Hirotaka, thank you for the package. I have only a few notes. > %global common_desc \ > Library for running OpenStack services There is a nice paragraph explaining the package in the project README - https://opendev.org/openstack/oslo.service Can we use that as a description? > %check > # FIXME: https://review.openstack.org/279011 seems to break tests in CentOS7, > # creating an infinite loop > #python3 setup.py test || > #rm -rf .testrepository Does this fail only for CentOS7? In such case, we can conditionally run the tests for the rest of the distributions, e.g. %if 0%{?fedora} || 0%{?rhel} > 7 # ... run your tests here %endif > * Wed Nov 16 2022 Hirotaka Wakabayashi hiwkby@xxxxxxxxx - 3.0.0-5 > * Wed Nov 09 2022 Hirotaka Wakabayashi hiwkby@xxxxxxxxx - 3.0.0-4 > * Tue Nov 08 2022 Hirotaka Wakabayashi hiwkby@xxxxxxxxx - 3.0.0-3 > * Tue Nov 01 2022 Hirotaka Wakabayashi hiwkby@xxxxxxxxx - 3.0.0-2 The email address should be in < and > brackets, as you did for your previous changelog records * Wed Oct 26 2022 Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> - 3.0.0-1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1991145 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
