[Bug 2116084] Review Request: python-pydiffx - Python implementation of the DiffX specification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2116084



--- Comment #10 from Carl George 🤠 <carl@xxxxxxxxxx> ---
> Upstream doesn't properly provide the info for the %generate_buildrequires to work.

It's preferred to patch the code to make %pyproject_buildrequires do the right
thing, and then send that patch upstream.

https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Automatically-generated-dependencies

You could add a 'test' extra to the setup.py file and do:

%pyproject_buildrequires -x test

Alternatively, you could use the GitHub tarball instead of the PyPI tarball,
which will let you do:

%pyproject_buildrequires python/dev-requirements.txt

> The proper runtime requirement is already in there.

Elliott is talking about including the runtime requirements as build
requirements, which is usually what you want for python packages.

> Yes, you'll need to pass `-r` to the macro to get runtime requirements as well.

No, that's been the default behavior for a while now.  The flag only exists now
for backwards compatibility.

https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_build_macros


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2116084
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux