[Bug 2134804] Review Request: perl-Alien-autoconf - Find autoconf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2134804



--- Comment #1 from Petr Salaba <psalaba@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
BuildArch is ok
BuildRequires are ok

Requires are not ok
> FIX: Remove these runtime dependencies, as we've discussed:
> Requires:       perl(alienfile) >= 0.49
> Requires:       perl(Capture::Tiny)
> Requires:       perl(File::Which)
> Requires:       perl(List::Util)
> Requires:       perl(Sort::Versions)
> Alien build using the alienfile only happens during srpm -> rpm build,
> these packages are not required at runtime.

Files section is ok
All tests passed

$ rpmlint perl-Alien-autoconf*.{spec,rpm}
================================== rpmlint session starts
==================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4

perl-Alien-autoconf-tests.noarch: W: no-documentation
perl-Alien-autoconf.spec:44: W: comparison-operator-in-deptoken 2>/dev/null)
perl-Alien-autoconf.spec:44: W: comparison-operator-in-deptoken 2>/dev/null)
=== 3 packages and 1 specfiles checked; 0 errors, 3 warnings, 0 badness; has
taken 0.3 s ===
rpmlint output is ok

$ rpm -q -lv -p perl-Alien-autoconf-0.18-1.fc38.x86_64.rpm
drwxr-xr-x    2 root     root                        0 Nov 16 12:25
/usr/lib64/perl5/vendor_perl/Alien
-rw-r--r--    1 root     root                     2558 Nov 16 12:25
/usr/lib64/perl5/vendor_perl/Alien/autoconf.pm
drwxr-xr-x    2 root     root                        0 Nov 16 12:25
/usr/lib64/perl5/vendor_perl/auto/Alien
drwxr-xr-x    2 root     root                        0 Nov 16 12:25
/usr/lib64/perl5/vendor_perl/auto/Alien/autoconf
-rw-r--r--    1 root     root                       65 Nov 16 12:25
/usr/lib64/perl5/vendor_perl/auto/Alien/autoconf/autoconf.txt
drwxr-xr-x    2 root     root                        0 Nov 16 12:25
/usr/lib64/perl5/vendor_perl/auto/share
drwxr-xr-x    2 root     root                        0 Nov 16 12:25
/usr/lib64/perl5/vendor_perl/auto/share/dist
drwxr-xr-x    2 root     root                        0 Nov 16 12:25
/usr/lib64/perl5/vendor_perl/auto/share/dist/Alien-autoconf
drwxr-xr-x    2 root     root                        0 Nov 16 12:25
/usr/lib64/perl5/vendor_perl/auto/share/dist/Alien-autoconf/_alien
-rw-r--r--    1 root     root                      401 Nov 16 12:25
/usr/lib64/perl5/vendor_perl/auto/share/dist/Alien-autoconf/_alien/alien.json
-rw-r--r--    1 root     root                     4413 Nov 16 12:25
/usr/lib64/perl5/vendor_perl/auto/share/dist/Alien-autoconf/_alien/alienfile
drwxr-xr-x    2 root     root                        0 Nov 16 12:25
/usr/share/doc/perl-Alien-autoconf
-rw-r--r--    1 root     root                     1722 Aug 12 00:07
/usr/share/doc/perl-Alien-autoconf/Changes
-rw-r--r--    1 root     root                     2695 Aug 12 00:07
/usr/share/doc/perl-Alien-autoconf/README
drwxr-xr-x    2 root     root                        0 Nov 16 12:25
/usr/share/licenses/perl-Alien-autoconf
-rw-r--r--    1 root     root                    18359 Aug 12 00:07
/usr/share/licenses/perl-Alien-autoconf/LICENSE
-rw-r--r--    1 root     root                     2191 Nov 16 12:25
/usr/share/man/man3/Alien::autoconf.3pm.gz
> FIX: Remove the following files from the package:
> /usr/lib64/perl5/vendor_perl/auto/share/dist/Alien-autoconf/_alien/alienfile
File layout and permissions are not ok

$ rpm -qp --requires perl-Alien-autoconf-0.18-1.fc38.src.rpm | sort | uniq -c |
grep -v rpmlib
      1 autoconf >= 2.69
      1 coreutils
      1 make
      1 perl(Alien::Base) >= 0.038
      1 perl(Alien::Build::MM) >= 0.32
      1 perl(Alien::Build::Plugin::Build::Autoconf) >= 0.47
      1 perl(alienfile) >= 0.49
      1 perl(Alien::m4)
      1 perl(base)
      1 perl(Capture::Tiny)
      1 perl(Config)
      1 perl(Env)
      1 perl(ExtUtils::MakeMaker) >= 6.76
      1 perl(File::chdir)
      1 perl(File::Temp)
      1 perl(File::Which)
      1 perl-generators
      1 perl-interpreter
      1 perl(List::Util)
      1 perl(Path::Tiny)
      1 perl(Sort::Versions)
      1 perl(strict)
      1 perl(Test2::V0) >= 0.000121
      1 perl(Test::Alien) >= 2.52
      1 perl(:VERSION) >= 5.8.1
      1 perl(warnings)
SRPM requires are ok

$ rpm -qp --requires perl-Alien-autoconf-0.18-1.fc38.x86_64.rpm | sort | uniq
-c | grep -v rpmlib
      1 autoconf = 2.71
      1 perl(Alien::Base) >= 0.038
      1 perl(alienfile) >= 0.49
      1 perl(base)
      1 perl(Capture::Tiny)
      1 perl(File::Which)
      1 perl(List::Util)
      1 perl(:MODULE_COMPAT_5.36.0)
      1 perl(Sort::Versions)
      1 perl(strict)
      1 perl(:VERSION) >= 5.8.1
      1 perl(warnings)
> FIX: Remove runtime dependencies (duplicate of FIX #1)
Binary requires for main package are not ok

$ rpm -qp --requires perl-Alien-autoconf-tests-0.18-1.fc38.noarch.rpm | sort |
uniq -c | grep -v rpmlib
      1 perl(Alien::autoconf)
      1 perl-Alien-autoconf = 0.18-1.fc38
      1 perl(Alien::m4)
      1 perl(Config)
      1 perl(Env)
      1 perl(File::chdir)
      1 perl(File::Temp)
      1 perl(Path::Tiny)
      1 perl(Test2::V0) >= 0.000121
      1 perl(Test::Alien) >= 2.52
      1 perl-Test-Harness
      1 /usr/bin/perl
      1 /usr/bin/sh
Binary requires for test subpackage are ok

$ rpm -qp --provides perl-Alien-autoconf-0.18-1.fc38.x86_64.rpm | sort | uniq
-c
      1 perl(Alien::autoconf) = 0.18
      1 perl-Alien-autoconf = 0.18-1.fc38
      1 perl-Alien-autoconf(x86-64) = 0.18-1.fc38
Binary provides are ok

Please resolve all 'FIX' items and provide a new spec file.

Resolution: Package NOT approved.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2134804
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux