[Bug 2144002] Review Request: python-phply - PHP parser written in Python using PLY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2144002



--- Comment #4 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Few more fixes needed

1) The BuildRequires: python3-pip is not needed
2) Add back %check as
%check
%py3_check_import %{pypi_name}

You should report upstream about replacing nose library in the testsuite run.
Also, See
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_running_tests
which says if you don't run upstream test for some reason at least run
%py3_check_import


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2144002
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux