https://bugzilla.redhat.com/show_bug.cgi?id=2143685 Kalev Lember <klember@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Doc Type|--- |If docs needed, set a value CC| |klember@xxxxxxxxxx Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |klember@xxxxxxxxxx --- Comment #1 from Kalev Lember <klember@xxxxxxxxxx> --- Fedora review rust-bindgen-cli-0.62.0-1.fc37.src.rpm 2022-11-22 $ rpmlint rust-bindgen-cli-0.62.0-1.fc37.src.rpm \ rust-bindgen-cli-debugsource-0.62.0-1.fc37.x86_64.rpm \ bindgen-cli-0.62.0-1.fc37.x86_64.rpm \ bindgen-cli-debuginfo-0.62.0-1.fc37.x86_64.rpm =================================================================================== rpmlint session starts =================================================================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 bindgen-cli-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/bindgen-0.62.0-1.fc37.x86_64.debug bindgen-cli.x86_64: E: unknown-key d2e40d55 bindgen-cli-debuginfo.x86_64: E: unknown-key d2e40d55 rust-bindgen-cli-debugsource.x86_64: E: unknown-key d2e40d55 bindgen-cli-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/bin/bindgen-0.62.0-1.fc37.x86_64.debug bindgen-cli.x86_64: W: no-manual-page-for-binary bindgen bindgen-cli-debuginfo.x86_64: W: no-documentation rust-bindgen-cli-debugsource.x86_64: W: no-documentation bindgen-cli-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/7f/e2ce96fb16f314feb208d884af96ac5145559b ../../../.build-id/7f/e2ce96fb16f314feb208d884af96ac5145559b ==================================================== 4 packages and 0 specfiles checked; 4 errors, 5 warnings, 4 badness; has taken 0.8 s ==================================================== + OK ! needs attention + rpmlint output looks good - the unknown-key warnings are because the packages are downloaded from Fabio's copr - unstripped-binary-or-object seems like something gone wrong with rpmlint checks: it's complaining about the -debuginfo subpackage where all the unstripped binaries have to go - shared-library-without-dependency-information is expected as much as I understand for rust packages as they are statically linked + The package is named according to Fedora packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. - The license field in the spec file matches the actual license I think you may have forgotten "Unlicense" out of the license tag? "Unlicense OR MIT" is listed for 3 dependent crates in LICENSE.dependencies. + The license text (BSD-3-Clause) is included in %license + Spec file is written in American English + Spec file is legible + Upstream sources match the sources in the srpm SHA512 (bindgen-cli-0.62.0.crate) = c0e5404f6d46ad80ec18f2ee36fa9d70af859bf82e26dae1dddbe324d40feb826c4abc05b6a0b3a66878280115e316e54bed82af153c06e3c53b32842ce74523 SHA512 (Download/bindgen-cli-0.62.0.crate) = c0e5404f6d46ad80ec18f2ee36fa9d70af859bf82e26dae1dddbe324d40feb826c4abc05b6a0b3a66878280115e316e54bed82af153c06e3c53b32842ce74523 + Package builds in copr n/a ExcludeArch bugs filed + BuildRequires look sane n/a locale handling + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all the directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect the runtime of application n/a Static libraries should be in -static n/a Development files should be in -devel n/a -devel must require the fully versioned base + Packages should not contain libtool .la files n/a Proper .desktop file handling + Doesn't own files or directories already owned by other packages + Filenames are valid UTF-8 + Package does not depend on deprecated packages APPROVED P.S. Please check if "Unlicense" is missing (as mentioned above) for the license tag before importing. P.P.S. I'll note that 0.63.0 was just released 38 minutes ago on https://crates.io/crates/bindgen-cli :) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2143685 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
