[Bug 2141868] Review Request: python-flake8-class-newline - Flake8 extension to check for new lines after class definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2141868

Wayne Sun <gsun@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |gsun@xxxxxxxxxx,
                   |                            |mhroncok@xxxxxxxxxx



--- Comment #1 from Wayne Sun <gsun@xxxxxxxxxx> ---
Similar to bug 2141871, could you do a mass update for bug 2141868, bug 2141870
and bug 2143071 on:

1) the description as variable
2) not use %srcname in URL

For current spec, the upstream haven't update or release package since 2017,
for the build as the flake8 versions in the dev test env have been updated
with:
# Relax maximum test dependency versions
sed -i 's/<[=0-9.]*,\?//' requirements-dev.txt

which will be updated in 

%pyproject_buildrequires -t

for the tox test requirements.

It works as test could pass.

@Miro any comment with update require version in spec? seems reasonable as for
packaging.

The upstream is with MIT licence and Modern Style with sublicense, so the SPDX
identifier in the spec is accurate.


The require info is accurate with:
Requires
--------
python3-flake8-class-newline (rpmlib, GLIBC filtered):
    python(abi)
    python3.11dist(flake8)

as in the setup.py:
https://github.com/AlexanderVanEck/flake8-class-newline/blob/master/setup.py#L32


The rpmlint also pass on srpm, spec and built rpm:
# rpmlint srpm/python-flake8-class-newline-1.6.0-1.fc38.src.rpm 
=================================================================== rpmlint
session starts
===================================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

==================================== 1 packages and 0 specfiles checked; 0
errors, 0 warnings, 0 badness; has taken 0.7 s
====================================
# rpmlint srpm/python-flake8-class-newline.spec 
=================================================================== rpmlint
session starts
===================================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

==================================== 0 packages and 1 specfiles checked; 0
errors, 0 warnings, 0 badness; has taken 0.7 s
====================================
# rpmlint results/python3-flake8-class-newline-1.6.0-1.fc38.noarch.rpm 
=================================================================== rpmlint
session starts
===================================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

==================================== 1 packages and 0 specfiles checked; 0
errors, 0 warnings, 0 badness; has taken 0.0 s
====================================

With test install on my laptop:
# dnf install results/python3-flake8-class-newline-1.6.0-1.fc38.noarch.rpm 
Last metadata expiration check: 0:00:38 ago on Tue 22 Nov 2022 04:40:26 PM GMT.
Error: 
 Problem: conflicting requests
  - nothing provides python(abi) = 3.11 needed by
python3-flake8-class-newline-1.6.0-1.fc38.noarch
  - nothing provides python3.11dist(flake8) needed by
python3-flake8-class-newline-1.6.0-1.fc38.noarch
(try to add '--skip-broken' to skip uninstallable packages)

the error is expected and the require info on the dependency match with 

python3-flake8-class-newline (rpmlib, GLIBC filtered):
    python(abi)
    python3.11dist(flake8)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2141868
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux