https://bugzilla.redhat.com/show_bug.cgi?id=2119240 --- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Orion Poplawski from comment #6) > It looks like we have an issue where the crate doesn't ship various image > files needed by the tests (tests/images). What's the best way forward here? Skip the tests which attempt to open files that aren't included in published crates ("%cargo_test -- -- --skip name_of_test"). If that doesn't work (for example, because the tests embed the contents of these files at build-time instead of opening them at run-time, i.e. with something like the "include_bytes!()" macro), then "rm tests/path_to_test.rs" the affected files in %prep. > Is it expected that they would be shipped in the crate? Can we shift to the > github source? No, that's not a good idea. We mandate using .crate files from crates.io for a reason. Mostly because it ensures that the crates successfully built before they were uploaded, and that the Cargo.toml metadata is normalized and has some extraneous stuff removed which could interfere with Fedora packaging tools. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2119240 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
