[Bug 2144589] Review Request: tpm2-openssl Provider for integration of TPM 2.0 to OpenSSL 3.0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2144589

Jakub Jelen <jjelen@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
         Whiteboard|                            |NotReady
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |jjelen@xxxxxxxxxx
                 CC|                            |jjelen@xxxxxxxxxx



--- Comment #2 from Jakub Jelen <jjelen@xxxxxxxxxx> ---
Did you use the template from [1][2] to create this bug? It provides fields
that are used by automation and that need to be filled in for stuff to work
correctly. Please update the bug with this information in new comment.

  Spec URL: <spec info here>
  SRPM URL: <srpm info here>
  Description: <description here>
  Fedora Account System Username:

Building the package in mock in rawhide fails for me during the tests. I assume
it will be some missing dependency for tests, but I did not investigate it
further yet. This needs to be fixed too

Do you have fedora account already? Are you in packager group? If not, we will
need FE-NEEDSPONSOR as described in [1].

The build is producing dozens of warnings, which should be possible to fix
pretty easily (if they are not fixed in the upstream), for example:

src/tpm2-provider-keymgmt-rsa.c: In function 'tpm2_rsa_keymgmt_gen':
src/tpm2-provider-keymgmt-rsa.c:302:1: warning: label 'final' defined but not
used [-Wunused-label]
  302 | final:
      | ^~~~~

This makes it hard to find real errors from the build log, but I think fixing
this is not a requirement for packaging (but a good practice that will
hopefully save some headaches in the future).

[1]
https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/
[2]
https://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&format=fedora-review


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2144589
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux