https://bugzilla.redhat.com/show_bug.cgi?id=2143005 --- Comment #5 from Tom Rix <trix@xxxxxxxxxx> --- I asked about cmake because it has a shared library, please see if you can get this to work. If it doesn't, patch the Makefile instead of sed-ing it The testing i was asking for was something like rpmbuild --with extra_tests There should be logic to run the unit testsuite and instructions on what type of machine to run it on. Think of someone other than yourself having to update the sources before making a new release. How would they verify that the library built correctly ? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2143005 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue