https://bugzilla.redhat.com/show_bug.cgi?id=2144097 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |mhroncok@xxxxxxxxxx Status|NEW |POST --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- > This is an informal review as I'm not a sponsor. Just a note about terminology (I know it is a lot) a sponsor is a person who can add members to the packager group (e.g me). To do a formal review, you don't need to be a sponsor, you just need to be "sponsored" -- a.k.a. be a member of the packager group. =========================== Upstream uses pytest-randomly to run the tests, which is packaged in Fedora, so we might as well do the same. All the test-deps are in requirements/requirements.in. Pseudo-diff: BuildRequires: python%{python3_pkgversion}-devel -BuildRequires: python%{python3_pkgversion}-pytest %generate_buildrequires -%pyproject_buildrequires +%pyproject_buildrequires requirements/requirements.in =========================== A total nit-pick about the spec - the number of blank lines between sections is generally 2, but there is only one blank line between %prep and %generate_buildrequires: %prep %autosetup -p1 -n %{srcname}-%{version} %generate_buildrequires %pyproject_buildrequires Anyway, APPROVED on your behalf. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2144097 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
