https://bugzilla.redhat.com/show_bug.cgi?id=2144002 --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Issues: ======= - Good to use upstream project URL as URL: https://github.com/viraptor/phply - Package must not depend on deprecated() packages. Note: python3-nose is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ ==> See https://fedoraproject.org/wiki/Changes/DeprecateNose#Detailed_Description You may ask upstream to change the test runner from nose library. You also don't need below deprecated macro line in SPEC file %{?python_provide:%python_provide python%{python3_pkgversion}-%{pypi_name}} - License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 3-Clause License", "Unknown or generated", "*No copyright* [generated file]". 21 files have unknown license. Detailed output of licensecheck in /home/test/2144002-python-phply/licensecheck.txt ==> license is "BSD-3-Clause" as per new SPDX expression format - Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.11/site- packages/tests(python3-flatpak-module-tools), /usr/lib/python3.11/site-packages/tests/__pycache__(python3-flatpak- module-tools) ==> I don't think we need tests directory content installed by this binary package. Running successfully tests in %check is sufficient. Drop below from %file %{python3_sitelib}/tests rpmlint on generated rpm files gives output as python3-phply.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/phply-1.2.5-py3.11.egg-info/not-zip-safe /usr/lib/python3.11/site-packages/phply-1.2.5-py3.11.egg-info/dependency_links.txt ==> This can be ignored as there are no contents in both files but they still got marked as duplicate python-phply.src: E: description-line-too-long phply is a parser for the PHP programming language written using PLY, a Lex/YACC-style parser generator toolkit for Python. python3-phply.noarch: E: description-line-too-long phply is a parser for the PHP programming language written using PLY, a Lex/YACC-style parser generator toolkit for Python. ==> per line in %description should be limited to 80 characters only -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2144002 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
