https://bugzilla.redhat.com/show_bug.cgi?id=2143804 --- Comment #4 from James Read <contact@xxxxxxxxx> --- Hey Fale, Many thanks indeed for your time looking into this today, it's really appreciated. 1. spec file and package renamed to OliveTin. That's originally what I wanted as well actually, so that's great. 2. Patch dropped - sorry, that was sloppy of me. I forgot to remove that line. 3. cp/chown -> install - I must have been doing something silly, but I tried for quite a long time to get the install command to work. Out of frustration I just used cp/chown in the end. Thanks for the help in fixing this, I would not have anticipated I needed to find/loop over files to install them. 4. systemd triggers: Ah, I thought they had been automatically added by existing RPM macros, but thank you for that. On the few suggestions you send me offline, the two I rejected where; - Changes to summary to add "OliveTin" - as this triggers a rpmlint warning. - %_sysconfigdir needed to be %_sysconfdir Commit c1ed6d6 should make this ready for review again; https://github.com/OliveTin/OliveTin-package-fedora/blob/main/OliveTin.spec -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2143804 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
