https://bugzilla.redhat.com/show_bug.cgi?id=2143919 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Two quick comments from Rust packaging POV: Please don't just downgrade dependencies, but let other Rust packagers know what you need. I already updated Fedora packages for env_logger 0.9.3, libc 0.2.137 a few days ago, and the update for regex 1.7.0 will happen soon. As for the updates to API-breaking newer versions of libudev and rust-ini, please comment on the bugs for these versions, or mark them as blocking this review request. Updates to API-breaking versions are only done on an as-needed basis, so unless I know something *needs* the new version, they won't be updated. Since this package also contains a Rust binary, you'll need to include a breakdown of statically linked components and their licenses. Luckily for you, I've recently worked on a macro to do that. You can add `%{cargo_license} > LICENSE.dependencies` after %cargo_build to automatically generate a file that contains all statically linked components and their licenses, which you can then include with `%license LICENSE.dependencies` in %files. You'll also need to add a separate License tag for the %{crate} package to reflect all listed licenses. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2143919 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
