https://bugzilla.redhat.com/show_bug.cgi?id=2143144 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Lukáš Zaoral from comment #1) > Thanks Jan, LGTM! Just two quick comments: > - The "Package does not contain duplicates in %files." is a false positive > as noted by Fabio Valentini in > https://bugzilla.redhat.com/show_bug.cgi?id=2138143#c5. This was also recently confirmed to me by Panu, the lead developer of RPM: https://bugzilla.redhat.com/show_bug.cgi?id=2138445#c5 > - The "Fully versioned dependency in subpackages if applicable." item is not > applicable since the given packages are noarch. This has nothing to do with packages being noarch or not - but either way, the necessary versioned dependencies are automatically generated by the RPM dependency generator for Rust crates and do not need to be added manually. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2143144 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
