https://bugzilla.redhat.com/show_bug.cgi?id=2138918 --- Comment #1 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Some notes * Probably unneeded BuildRequires - Please check if "BR: rubygem(rake)" is really needed. - Also we usually try to remove "BR: rubygem(bundler)", as bundler tries to lock the version of other dependency gems, which we don't want as we are using rpm ecosystem. It seems that removing "require 'bundler/setup'" from spec/spec_helper.rb is sufficient. * Documentation - "Rakefile" is something like "Makefile in Ruby" and usually this is not considered as documentation. - Not a blocker, however I would request "README.md" to be packaged into main package, not in -doc, as README.md is expected to be read by everyone using this rpm. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2138918 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
