https://bugzilla.redhat.com/show_bug.cgi?id=2143827 Davide Cavalca <davide@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |davide@xxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |davide@xxxxxxxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED --- Comment #1 from Davide Cavalca <davide@xxxxxxxxxxxx> --- Taking this review, and I'm happy to sponsor you. Blockers: - the license tag is MIT, but the upstream project doesn't seem to have an explicit license and doesn't include a license file (which is a requirement for most licenses, and for MIT in particular); please ask upstream to clarify the project license and to ideally include a LICENSE file, and then add it to the package with %license in the files section - as you're packaging a git snapshot, the version needs to be set accordingly per https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ ; look at https://src.fedoraproject.org/rpms/crosswords-puzzle-sets-gnome for an example Please fix: - URL should point to the actual URL of the project, i.e. https://github.com/povik/alsa-ucm-conf-asahi - you'll want to install the README.asahi using %doc in the files section Nits and suggestions: - the description should be a full sentence and end with a period - you can drop the %{_builddir}/%{git_name}-%{_commit_id} in the %install section -- that's already your current directory - it's not obvious why you require coreutils, I'd recommend adding a comment - the changelog entry is valid, but it deviates from the convention sightly: you have a double space between the date and the name, and you're missing a dash between email and version -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2143827 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
