https://bugzilla.redhat.com/show_bug.cgi?id=2140316 --- Comment #2 from Sandro Mani <manisandro@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package requires R-core. - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Packages have proper BuildRequires/Requires on javapackages-tools (jpackage-utils) - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation => Pregenerated javadocs exist in rJava/inst/javadoc - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Bundled jar/class files should be removed before build Note: Jar files in source (see attachment) See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Java/#_pre_built_dependencies => Remove rJava/inst folder in %prep ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GNU Lesser General Public License, Version 2.1", "Unknown or generated", "FSF Unlimited License [generated file]", "*No copyright* GNU General Public License v2.0 or later", "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Lesser General Public License", "X11 License [generated file]", "GNU General Public License v2.0 or later", "GNU General Public License v2.0 only", "GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]", "*No copyright* [generated file]", "GNU General Public License v3.0 or later", "MIT License". 371 files have unknown license. Detailed output of licensecheck in /home/sandro/Desktop/2140316-R-rJava/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Maven: [ ]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used R: [x]: Package contains the mandatory BuildRequires. [x]: The package has the standard %install section. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. Java: [ ]: Packages are noarch unless they use JNI Note: R-rJava subpackage is not noarch. Please verify manually [ ]: Package uses upstream build method (ant/maven/etc.) R: [x]: The %check macro is present [x]: Latest version is packaged. Note: Latest upstream version is 1.0.6, packaged version is 1.0.6 ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: R-rJava-1.0.6-1.fc38.x86_64.rpm R-rJava-debuginfo-1.0.6-1.fc38.x86_64.rpm R-rJava-debugsource-1.0.6-1.fc38.x86_64.rpm R-rJava-1.0.6-1.fc38.src.rpm ======================================================================================= rpmlint session starts ====================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmprmj6t7a9')] checks: 31, packages: 4 R-rJava.x86_64: W: package-with-huge-docs 63% R-rJava.x86_64: W: hidden-file-or-dir /usr/lib64/R/library/rJava/help/.DollarNames.jarrayRef.html R-rJava.x86_64: W: hidden-file-or-dir ... [snip] ... R-rJava.x86_64: E: files-duplicated-waste 306747 R-rJava.x86_64: W: files-duplicate /usr/lib64/R/library/rJava/help/jequals.html /usr/lib64/R/library/rJava/help/+21+3D+2CANY+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+21+3D+2CjobjRef+2CANY-method.html:/usr/lib64/R/library/rJava/help/+21+3D+2CjobjRef+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3C+2CANY+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3C+2CjobjRef+2CANY-method.html:/usr/lib64/R/library/rJava/help/+3C+2CjobjRef+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3C+3D+2CANY+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3C+3D+2CjobjRef+2CANY-method.html:/usr/lib64/R/library/rJava/help/+3C+3D+2CjobjRef+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3D+3D+2CANY+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3D+3D+2CjobjRef+2CANY-method.html:/usr/lib64/R/library/rJava/help/+3D+3D+2CjobjRef+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3E+2CANY+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3E+2CjobjRef+2CANY-method.html:/usr/lib64/R/library/rJava/help/+3E+2CjobjRef+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3E+3D+2CANY+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3E+3D+2CjobjRef+2CANY-method.html:/usr/lib64/R/library/rJava/help/+3E+3D+2CjobjRef+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/.jcompare.html:/usr/lib64/R/library/rJava/help/.jequals.html R-rJava.x86_64: W: files-duplicate ... [snip] ... R-rJava.x86_64: W: file-not-utf8 /usr/lib64/R/library/rJava/javadoc/member-search-index.zip R-rJava.x86_64: W: file-not-utf8 /usr/lib64/R/library/rJava/javadoc/package-search-index.zip R-rJava.x86_64: W: file-not-utf8 /usr/lib64/R/library/rJava/javadoc/type-search-index.zip ======================================================= 4 packages and 0 specfiles checked; 1 errors, 77 warnings, 1 badness; has taken 0.7 s ======================================================= Rpmlint (debuginfo) ------------------- Checking: R-rJava-debuginfo-1.0.6-1.fc38.x86_64.rpm ======================================================================================= rpmlint session starts ====================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7msq3zy3')] checks: 31, packages: 1 ======================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s ======================================================= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 R-rJava.x86_64: W: unused-direct-shlib-dependency /usr/lib64/R/library/rJava/jri/libjri.so libjvm.so R-rJava.x86_64: W: unused-direct-shlib-dependency /usr/lib64/R/library/rJava/libs/rJava.so libjvm.so R-rJava.x86_64: W: undefined-non-weak-symbol /usr/lib64/R/library/rJava/jri/libjri.so JNI_GetCreatedJavaVMs R-rJava.x86_64: W: undefined-non-weak-symbol /usr/lib64/R/library/rJava/libs/rJava.so JNI_GetCreatedJavaVMs R-rJava.x86_64: W: undefined-non-weak-symbol /usr/lib64/R/library/rJava/libs/rJava.so JNI_CreateJavaVM R-rJava.x86_64: W: undefined-non-weak-symbol /usr/lib64/R/library/rJava/libs/rJava.so JNI_GetDefaultJavaVMInitArgs R-rJava.x86_64: W: package-with-huge-docs 63% R-rJava.x86_64: W: hidden-file-or-dir ... [snip] ... R-rJava.x86_64: E: files-duplicated-waste 306747 R-rJava.x86_64: W: files-duplicate /usr/lib64/R/library/rJava/help/jequals.html /usr/lib64/R/library/rJava/help/+21+3D+2CANY+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+21+3D+2CjobjRef+2CANY-method.html:/usr/lib64/R/library/rJava/help/+21+3D+2CjobjRef+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3C+2CANY+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3C+2CjobjRef+2CANY-method.html:/usr/lib64/R/library/rJava/help/+3C+2CjobjRef+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3C+3D+2CANY+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3C+3D+2CjobjRef+2CANY-method.html:/usr/lib64/R/library/rJava/help/+3C+3D+2CjobjRef+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3D+3D+2CANY+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3D+3D+2CjobjRef+2CANY-method.html:/usr/lib64/R/library/rJava/help/+3D+3D+2CjobjRef+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3E+2CANY+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3E+2CjobjRef+2CANY-method.html:/usr/lib64/R/library/rJava/help/+3E+2CjobjRef+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3E+3D+2CANY+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/+3E+3D+2CjobjRef+2CANY-method.html:/usr/lib64/R/library/rJava/help/+3E+3D+2CjobjRef+2CjobjRef-method.html:/usr/lib64/R/library/rJava/help/.jcompare.html:/usr/lib64/R/library/rJava/help/.jequals.html R-rJava.x86_64: W: files-duplicate ... [snip] ... R-rJava.x86_64: W: file-not-utf8 /usr/lib64/R/library/rJava/javadoc/member-search-index.zip R-rJava.x86_64: W: file-not-utf8 /usr/lib64/R/library/rJava/javadoc/package-search-index.zip R-rJava.x86_64: W: file-not-utf8 /usr/lib64/R/library/rJava/javadoc/type-search-index.zip 3 packages and 0 specfiles checked; 1 errors, 83 warnings, 1 badness; has taken 1.1 s Unversioned so-files -------------------- R-rJava: /usr/lib64/R/library/rJava/jri/libjri.so R-rJava: /usr/lib64/R/library/rJava/libs/rJava.so Source checksums ---------------- https://cran.r-project.org/package=rJava&version=1.0-6#/rJava_1.0-6.tar.gz : CHECKSUM(SHA256) this package : e290d0493317a5d6c452793e92baa914e37ef03faef19b2e436329b4ec8658c6 CHECKSUM(SHA256) upstream package : e290d0493317a5d6c452793e92baa914e37ef03faef19b2e436329b4ec8658c6 Requires -------- R-rJava (rpmlib, GLIBC filtered): /usr/bin/sh R(ABI) R(methods) R-core libR.so()(64bit) libc.so.6()(64bit) libjvm.so()(64bit) libjvm.so(SUNWprivate_1.1)(64bit) rtld(GNU_HASH) R-rJava-debuginfo (rpmlib, GLIBC filtered): R-rJava-debugsource (rpmlib, GLIBC filtered): Provides -------- R-rJava: R(rJava) R-rJava R-rJava(x86-64) libjri.so()(64bit) R-rJava-debuginfo: R-rJava-debuginfo R-rJava-debuginfo(x86-64) debuginfo(build-id) libjri.so-1.0.6-1.fc38.x86_64.debug()(64bit) R-rJava-debugsource: R-rJava-debugsource R-rJava-debugsource(x86-64) Jar and class files in source ----------------------------- ./rJava/rJava/inst/jri/JRIEngine.jar ./rJava/rJava/inst/jri/REngine.jar ./rJava/rJava/inst/java/RJavaArrayTools.class ./rJava/rJava/inst/java/RectangularArrayExamples.class ./rJava/rJava/inst/java/RectangularArrayBuilder_Test.class ./rJava/rJava/inst/java/RJavaTools_Test$ExampleClass.class ./rJava/rJava/inst/java/DummyPoint.class ./rJava/rJava/inst/java/RJavaArrayTools$ArrayDimensionMismatchException.class ./rJava/rJava/inst/java/boot/RJavaClassLoader$UnixJarFile.class ./rJava/rJava/inst/java/boot/RJavaClassLoader.class ./rJava/rJava/inst/java/boot/RJavaClassLoader$UnixFile.class ./rJava/rJava/inst/java/boot/RJavaClassLoader$RJavaObjectInputStream.class ./rJava/rJava/inst/java/boot/RJavaClassLoader$UnixDirectory.class ./rJava/rJava/inst/java/RectangularArraySummary.class ./rJava/rJava/inst/java/ArrayWrapper_Test.class ./rJava/rJava/inst/java/RJavaArrayIterator.class ./rJava/rJava/inst/java/PrimitiveArrayException.class ./rJava/rJava/inst/java/ArrayDimensionException.class ./rJava/rJava/inst/java/NotAnArrayException.class ./rJava/rJava/inst/java/ObjectArrayException.class ./rJava/rJava/inst/java/RJavaTools_Test$TestException.class ./rJava/rJava/inst/java/RJavaTools_Test$DummyNonStaticClass.class ./rJava/rJava/inst/java/FlatException.class ./rJava/rJava/inst/java/ArrayWrapper.class ./rJava/rJava/inst/java/RJavaImport.class ./rJava/rJava/inst/java/RJavaComparator.class ./rJava/rJava/inst/java/TestException.class ./rJava/rJava/inst/java/RJavaTools_Test.class ./rJava/rJava/inst/java/RJavaArrayTools_Test.class ./rJava/rJava/inst/java/RJavaTools.class ./rJava/rJava/inst/java/NotComparableException.class ./rJava/rJava/inst/java/RectangularArrayBuilder.class ./rJava/rJava/jri/tools/getsp.class ./rJava/rJava/src/java/RJavaArrayTools.class ./rJava/rJava/src/java/RectangularArrayExamples.class ./rJava/rJava/src/java/RectangularArrayBuilder_Test.class ./rJava/rJava/src/java/RJavaTools_Test$ExampleClass.class ./rJava/rJava/src/java/DummyPoint.class ./rJava/rJava/src/java/RJavaClassLoader$UnixJarFile.class ./rJava/rJava/src/java/RJavaArrayTools$ArrayDimensionMismatchException.class ./rJava/rJava/src/java/RJavaClassLoader.class ./rJava/rJava/src/java/RectangularArraySummary.class ./rJava/rJava/src/java/ArrayWrapper_Test.class ./rJava/rJava/src/java/RJavaArrayIterator.class ./rJava/rJava/src/java/PrimitiveArrayException.class ./rJava/rJava/src/java/ArrayDimensionException.class ./rJava/rJava/src/java/NotAnArrayException.class ./rJava/rJava/src/java/ObjectArrayException.class ./rJava/rJava/src/java/RJavaTools_Test$TestException.class ./rJava/rJava/src/java/RJavaTools_Test$DummyNonStaticClass.class ./rJava/rJava/src/java/FlatException.class ./rJava/rJava/src/java/ArrayWrapper.class ./rJava/rJava/src/java/RJavaImport.class ./rJava/rJava/src/java/RJavaClassLoader$UnixFile.class ./rJava/rJava/src/java/RJavaComparator.class ./rJava/rJava/src/java/TestException.class ./rJava/rJava/src/java/RJavaTools_Test.class ./rJava/rJava/src/java/RJavaArrayTools_Test.class ./rJava/rJava/src/java/RJavaClassLoader$RJavaObjectInputStream.class ./rJava/rJava/src/java/RJavaClassLoader$UnixDirectory.class ./rJava/rJava/src/java/RJavaTools.class ./rJava/rJava/src/java/NotComparableException.class ./rJava/rJava/src/java/RectangularArrayBuilder.class ./rJava/rJava/tools/getsp.class Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2140316 Buildroot used: fedora-rawhide-x86_64 Active plugins: R, Java, Shell-api, Generic, C/C++ Disabled plugins: fonts, Perl, PHP, Ocaml, Python, SugarActivity, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2140316 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
