Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request CppAD - A Package for Differentiation of C++ Algorithms https://bugzilla.redhat.com/show_bug.cgi?id=416761 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-12-20 09:30 EST ------- Please provide a new srpm also (which release number changed every time you modify your spec/srpm) so that we can try to rebuild your srpm easily. (In reply to comment #3) > (In reply to comment #2) > > * If some tests are executable, the move them to %check section > > and remove %{_validation_testing_during_rpmbuild} related description. > > I cannot find any documentation or examples for using %check in a spec file. For example: http://cvs.fedoraproject.org/viewcvs/*checkout*/devel/ruby-romkan/ruby-romkan.spec http://cvs.fedoraproject.org/viewcvs/*checkout*/devel/tokyocabinet/tokyocabinet.spec > > * support parallel make if possible. > > I think that the new BuildRoot command does this (but I cannot find > documentation for %(%{__id_u} -n)). Well, please refer to the section "Parallel make" of http://fedoraproject.org/wiki/Packaging/Guidelines (paralle make I say here has no relation with %_id_u) > > - And please use %configure if possible (please check what > > %configure actually does by > > $ rpm --eval %configure ) > > Currently, --with-Documentation is needed on the cppad configure line to get the > documentation. Doesn't "%configure --with-Documentation" work? > > * Please use macros. > > http://fedoraproject.org/wiki/Packaging/RPMMacros > > - For example, /usr must be %_prefix. > > Done. Please use more (please check "RPMMacros" page again). /usr/include, /usr/share/doc must be changed. BTW files under %_docdir are automatically marked as %doc. !! # 2. What does the '?' mean in the Release command below ? As written in http://fedoraproject.org/wiki/Packaging/DistTag, --------------------------------------------------------- If %{dist} is defined, insert its value here. If not, do nothing. --------------------------------------------------------- # 3. What does the __id_u and -n mean in the BuildRoot command below ? You can check this by $ rpm --eval %__id_u $ rpm --eval '%(%__id_u -n)' to see what actually happens. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review