https://bugzilla.redhat.com/show_bug.cgi?id=2141070 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks for confirming with upstream that the intended license is MIT. Though I'm still unsure whether just relicensing a forked project like that is actually sound ... At least in this case, the license is "compatible" in the sense that it only takes away the Apache-2.0 choice. > As for your suggestion of including the license text manually I don't think it's appropriate to do since our guidelines are clear to only include it if it's included in the source package (it's not in the 2.11.2 crate) or manually include a copy when the license requires a copy of the full license text to be included (MIT does not require that). It's going to get fixed anyway as soon as we update to a newer version where the license text is included. I'm very sure that you're misremembering things here. MIT is indeed one of the licenses where full license text in redistributed sources is required. Additionally, the Packaging Guidelines only forbid including license texts that are separate from *upstream*, but including the actual upstream license text is OK if it's not in the tarball but only in the git repo (as is the case here). But other than that, the package looks good to me. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora ! license file is included with %license in %files (will be fixed) - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2141070 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
