https://bugzilla.redhat.com/show_bug.cgi?id=2141871 Wayne Sun <gsun@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gsun@xxxxxxxxxx, | |mhroncok@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Wayne Sun <gsun@xxxxxxxxxx> --- This is an informal review as I'm not a sponsor 1. Define the description as global variable, then use it for both overall description and package description, please take the fedora packaging guide example spec file [a] as reference 2. Use Source instead of Source0, it's more modern and packaging guide have updated to use it, more info could be found https://pagure.io/packaging-committee/pull-request/1157 [a] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_empty_spec_file -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2141871 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
