https://bugzilla.redhat.com/show_bug.cgi?id=2142178 --- Comment #5 from Neal Gompa <ngompa13@xxxxxxxxx> --- (In reply to Omair Majid from comment #4) > Thanks! > > Here's the updated package: > > Spec URL: https://pagure.io/dotnet-sig/dotnet7.0/raw/main/f/dotnet7.0.spec > SRPM URL: > https://download.copr.fedorainfracloud.org/results/%40dotnet-sig/dotnet- > preview/srpm-builds/05035862/dotnet7.0-7.0.100-0.fc36.1.src.rpm > > Copr build: > https://copr.fedorainfracloud.org/coprs/g/dotnet-sig/dotnet-preview/build/ > 5035862/ > > > * I'd prefer you kept the original changelog fully intact and added a new entry on top rather than blowing away chunks of the changelog > > I actually started working on this package a long time ago (probably around > June). I couldn't propose to add it to Fedora back then because it wouldn't > build and/or bootstrap until recently. The changelog diff is just a > reflection of that. I can re-add the recent entries from dotnet6.0's > changelog if you still prefer that. > > Oh, that makes sense. Don't worry about it then. > > * You should consider making a variable and using it everywhere that "7.0" is used so that it's easy to change and reduces the diff in the future (e.g. %dotnetver or something?) > > * Man pages are not guaranteed to have .gz extension (we could change to zstd compression in the future, for example), so use ".*" instead of ".gz" > > * Release "0.1%{?dist}" will create upgrade problems. Use "0%{?dist}.1" instead. > > Thanks, all these should be fixed now. > > > * Your conditional for the "dotnet" subpackage currently makes it get generated for RHEL < 9 *and* Fedora. Is that intentional? > > Kind of. Back when we added dotnet3.1 to Fedora, we had a `dotnet` > subpackage to let users install the latest version of .NET/.NET Core. It was > a mistake to have that because it's rarely what users want. Different > versions of .NET aren't compatible with each other. Out of the box, a piece > of code that wants .NET 6 will simply not work against .NET 7. So users > generally want an explicit version of dotnet - and we should help them make > that decision explicitly at install time. For RHEL 9, since it was a new OS, > we could remove the dotnet subpackage without any issues. But we kept that > subpacakge around in Fedora to keep different versions of .NET in different > versions of Fedora consistent. > > Is it okay if we leave this subpackage out Fedora starting with .NET 7? That > means only dotnet6.0 (and earlier) will provide that package and users will > get dotnet-sdk-6.0 installed if they ask for `dotnet`. It seems weird that we'd drop it though, given that we have the dotnet-host package generated too. I think it makes sense to have an unversioned package that gives you the latest one. That said, it does make sense to me that RHEL wouldn't have this anymore, given that you'll keep adding new versions across the same major RHEL version. But if you really want to drop it, the conditional is not very clear on that. And all the other dotnet packages will need cleanup for that too... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2142178 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
