https://bugzilla.redhat.com/show_bug.cgi?id=2142178 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec diff review: * I'd prefer you kept the original changelog fully intact and added a new entry on top rather than blowing away chunks of the changelog * You should consider making a variable and using it everywhere that "7.0" is used so that it's easy to change and reduces the diff in the future (e.g. %dotnetver or something?) * Man pages are not guaranteed to have .gz extension (we could change to zstd compression in the future, for example), so use ".*" instead of ".gz" * Your conditional for the "dotnet" subpackage currently makes it get generated for RHEL < 9 *and* Fedora. Is that intentional? * Release "0.1%{?dist}" will create upgrade problems. Use "0%{?dist}.1" instead. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2142178 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
