Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Email-Date-Format - Produce RFC 2822 date strings https://bugzilla.redhat.com/show_bug.cgi?id=426299 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-12-20 00:52 EST ------- Everything looks good to me. * source files match upstream: 0c7f3636dffa5ff151f6906baa17582c2efeb29109750f40f820fe5d2dc38e84 Email-Date-Format-1.002.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Email::Date::Format) = 1.002 perl-Email-Date-Format = 1.002-1.fc9 = perl >= 0:5.006 perl(:MODULE_COMPAT_5.8.8) perl(Exporter) perl(Time::Local) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=3, Tests=5, 0 wallclock secs ( 0.10 cusr + 0.03 csys = 0.13 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review