https://bugzilla.redhat.com/show_bug.cgi?id=2065938 --- Comment #6 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- > As for the scriptlets I see, thank you very much for the explanation and for the additional comments in the spec file. I already wanted to give +1 but the fedora-review tool revealed a couple more things. > [ ]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. > > Unversioned so-files > -------------------- > chibi-scheme: /usr/lib64/chibi/chibi/ast.so > chibi-scheme: /usr/lib64/chibi/chibi/crypto/crypto.so > chibi-scheme: /usr/lib64/chibi/chibi/disasm.so > chibi-scheme: /usr/lib64/chibi/chibi/emscripten.so > chibi-scheme: /usr/lib64/chibi/chibi/filesystem.so > ... Do you understand what is wrong here? My understanding is that those should be provided by the chibi-scheme-devel package or there should be a number suffix in those names, e.g. ast.so.0 But I must admit that it is outside of my scope so I mainly just hope that you know what is going on here :-) > MIT License > ----------- > chibi-scheme-0.10.0/lib/srfi/101.scm > chibi-scheme-0.10.0/lib/srfi/135.scm > chibi-scheme-0.10.0/lib/srfi/135.sld > chibi-scheme-0.10.0/lib/srfi/135/kernel8.body.scm > chibi-scheme-0.10.0/lib/srfi/135/kernel8.sld > chibi-scheme-0.10.0/lib/srfi/135/test.sld >From https://synthcode.com/scheme/chibi/#h2_SnowPackageManager > Beyond the distributed modules, Chibi comes with a package manager > based on Snow2 ... Should the lib be bundled or installed as a separate package? If bundled, I guess we will have to mention MIT in the License field License: BSD-3-Clause AND MIT > [!]: Spec file according to URL is the same as in SRPM. > Note: Spec file as given by url is not the same as in SRPM (see > attached diff). > See: (this test has no URL) I guess you forgot to rebuild your SRPM package after updating the spec file? Diff spec file in url and in SRPM --------------------------------- --- /home/jkadlcik/2065938-chibi-scheme/srpm/chibi-scheme.spec 2022-11-11 19:25:34.442506969 +0100 +++ /home/jkadlcik/2065938-chibi-scheme/srpm-unpacked/chibi-scheme.spec 2022-11-11 18:32:05.000000000 +0100 @@ -1,2 +1,11 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.3.0) +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global _description %{expand: Chibi-Scheme is a very small library intended for use as an extension @@ -89,3 +98,4 @@ %changelog -%autochangelog +* Fri Nov 11 2022 John Doe <packager@xxxxxxxxxxx> 0.10.0-1 +- Uncommitted changes -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2065938 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
