https://bugzilla.redhat.com/show_bug.cgi?id=2141038 --- Comment #2 from Miroslav Lichvar <mlichvar@xxxxxxxxxx> --- Thanks for the review. I fixed the changelog, added a simple test and fixed one of the compiler warnings in: Spec URL: https://fedorapeople.org/~mlichvar/tmp/synce4l.spec SRPM URL: https://fedorapeople.org/~mlichvar/tmp/synce4l-0-2.20221108git079577.fc38.src.rpm As for the other issues, I think %makeinstall relies on the project having a configure script or something that would remember bindir, sbindir, mandir and all other paths as %makeinstall just sets DESTDIR. The other compiler warning is in code taken from linuxptp, so I think I should try to fix it there first. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2141038 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
