https://bugzilla.redhat.com/show_bug.cgi?id=2140295 --- Comment #2 from fedepell <fede@xxxxxxxxxxxx> --- Hello! Looks mostly all fine! Minor comments: -) Dependencie just wonderign: you added sympy which is an optional, but not pyarrow which is the other optional, is there a reason for this? > BuildRequires: python3-sympy Just another side note on dependencies: due to "python3dist(typing-extensions) >= 4.2" this will only build with FC37 or higher. And of course depending if you release interface-meta (and its dependencies) in FC37 in the future :-) -) Add license file explicitly that is missing? So add under %files: > %license LICENSE -) I read the comments on the disabled tests and the upstream thread. I saw they were just recently fixed here: https://github.com/matthewwardrop/formulaic/commit/e5dedcb0feed39f5ff6e2326d727ca65d247f26d Would it be worth to add this patch (to be removed at next package update) so then we can run all the tests probably? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2140295 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
