[Bug 2030050] Review Request: tinysa-saver - Tool for reading, displaying and saving data from the tinySA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2030050



--- Comment #1 from Ali Erdinc Koroglu <aekoroglu@xxxxxxxxxxxxxxx> ---
I changed python macro, SPDX license and did some makeup :)

--- a/tinysa-saver.spec 2021-12-07 22:34:48.000000000 +0200
+++ b/tinysa-saver.spec 2022-11-08 10:28:15.981892142 +0200
@@ -5,27 +5,25 @@
 Version:   0.11
 Release:   1%{?dist}
 Summary:   Tool for reading, displaying and saving data from the TinySA
-License:   GPLv3
-URL:       https://github.com/erikkaashoek/tinySA-saver

+License:   GPL-3.0-or-later
+URL:       https://github.com/erikkaashoek/tinySA-saver
 Source0:   %{URL}/archive/v%{version}/%{name}-%{version}.tar.gz
 # Reported upstream: https://github.com/mihtjel/nanovna-saver/issues/163
 Source1:   tinysa-saver.desktop
+
+# OS/distro specific
+Patch0:         tinysa-saver-0.11-fedora-icon.patch
+# original patch
+# https://github.com/mihtjel/nanovna-saver/pull/162
+Patch1:         tinysa-saver-0.11-test-fix.patch
+
 BuildArch: noarch
-BuildRequires: python3-setuptools
+
 BuildRequires: python3-devel
-BuildRequires: python3-pyserial
-BuildRequires: python3-numpy
-BuildRequires: python3-scipy
-BuildRequires: python3-qt5
-BuildRequires: sed
+BuildRequires: python3-pytest
 BuildRequires: desktop-file-utils
 Requires:  hicolor-icon-theme
-# OS/distro specific
-Patch0:        tinysa-saver-0.11-fedora-icon.patch
-# original patch
-# https://github.com/mihtjel/nanovna-saver/pull/162
-Patch1:        tinysa-saver-0.11-test-fix.patch

 %description
 A multiplatform tool to save scans from the TinySA, sweep frequency
@@ -33,17 +31,20 @@
 display and analyze the resulting data.

 %prep
-%setup -q
-%autopatch -p1
+%autosetup -p1 -n %{name}-%{version}

 # Drop shebang of non-executable
 sed -i '1 d' TinySASaver/__main__.py

+%generate_buildrequires
+%pyproject_buildrequires
+
 %build
-%py3_build
+%pyproject_wheel

 %install
-%py3_install
+%pyproject_install
+%pyproject_save_files TinySASaver

 # drop the tests, we do not need them in production, do not use rm -rf
 pushd %{buildroot}%{python3_sitelib}
@@ -63,14 +64,11 @@
   %{SOURCE1}

 %check
-%{python3} setup.py test
+%pytest -v

-%files
-%license LICENSE
+%files -n %{name} -f %{pyproject_files}
 %doc README.md
 %{_bindir}/TinySASaver
-%{python3_sitelib}/TinySASaver
-%{python3_sitelib}/TinySASaver-%{pyversion}-py*.egg-info
 %{_datadir}/icons/hicolor/48x48/apps/%{name}.png
 %{_datadir}/applications/%{name}.desktop


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2030050
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux