https://bugzilla.redhat.com/show_bug.cgi?id=2133456 --- Comment #2 from fedepell <fede@xxxxxxxxxxxx> --- Hi Dominik! > Version: 0.3 I saw in the meantime 0.3.1 was released, which also fixes the version problem you are patching. Let's bump to that one and drop the version patch? > License: GPLv2+ Should be "GPL-2.0-or-later" I believe now with SPDX. > Source0: https://gitlab.freedesktop.org/libevdev/hid-tools/-/archive/%{version}/hid-tools-%{version}.tar.bz2 Maybe change to: Source0: %{url}/-/archive/%{version}/hid-tools-%{version}.tar.bz2 I see rpmlint will complain about: > python3-hidtools.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/hidtools/cli/decode.py 644 /bin/env python3 > python3-hidtools.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/hidtools/cli/feature.py 644 /bin/env python3 > python3-hidtools.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/hidtools/cli/parse_hid.py 644 /bin/env python3 > python3-hidtools.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/hidtools/cli/record.py 644 /bin/env python3 > python3-hidtools.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/hidtools/cli/replay.py 644 /bin/env python3 > python3-hidtools.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/hidtools/hid.py 644 /bin/env python3 > python3-hidtools.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/hidtools/hidraw.py 644 /bin/env python3 > python3-hidtools.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/hidtools/hut.py 644 /bin/env python3 > python3-hidtools.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/hidtools/uhid.py 644 /bin/env python3 > python3-hidtools.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/hidtools/util.py 644 /bin/env python3 Indeed some have a "main" inside so could be potentially executed directly, some don't so having the shebang is a bit strange although not a problem. But this is something that may be discussed with upstream, not sure something to worry too much of. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2133456 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
