https://bugzilla.redhat.com/show_bug.cgi?id=2116088 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Doc Type|--- |If docs needed, set a value Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- There's some issues with the current version of this package: 1. upstream project does not include license files You should file a PR with upstream to include LICENSE-APACHE and LICENSE-MIT files. Additionally, the link to the MIT license that you used points at an HTML page, not a plaintext version. Please attempt to resolve this with upstream (i.e. "Copyright <YEAR> <COPYRIGHT HOLDER>" placeholder text also needs to be resolved somehow). I suspect the resolution will be similar to the one in the package for strength_reduce, given that it's the same upstream developer ... 2. drop criterion dependency entirely The "criterion" library is only used in benchmark code. It is safe to remove it entirely from Fedora packages, since we neither build nor run benchmark code. Keeping the dependency usually just inflates the dependency tree and package build times by a huuuuuuge amount. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2116088 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
