https://bugzilla.redhat.com/show_bug.cgi?id=2139873 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- fedora-review complains: - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license.html is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text But I think this is a false positive: the file is /usr/share/doc/python-netapp_ontap-doc/docs/models/license.html and it seems to contain documentation for class LicenseSchema. -- The name should have a dash, not an underscore. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming doesn't say this very clearly, but it says that the package name should use the canonical name, and the canonical name is described as the project name with some canonicalization, and the project name is described as the name used on pypi. And on pypi we have a dash: https://pypi.org/project/netapp-ontap/ -- OK, between the license and a potential name change, I'll wait for an update. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2139873 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue