[Bug 2138486] Review Request: python-crossword - Python library for handling crossword puzzles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2138486



--- Comment #2 from Davide Cavalca <dcavalca@xxxxxx> ---
(In reply to Jakub Kadlčík from comment #1)
> Looks good to me, I won't block the review because of this. But can
> you please create an upstream issue asking them to publish tags on GitHub?

https://github.com/svisser/crossword/issues/4

> Also, I am not quite sure how to validate that the commit corresponds
> to the PyPI package. Can you please explain, how you do it? I would
> like to write some code to `fedora-review` or create a separate script
> for this.

The heuristics I use are roughly:
- check when the pypi package was published and find a commit on/around that
date
- ideally look for a commit that updates or sets a version that matches with
the pypi one
- compare the contents of the tree at the commit with the contents of the pypi
source (assuming there is a source, as some packages -- not this one thankfully
-- only publish wheels)

Put together, these usually surface enough clues to find a good candidate, but
I'm not sure how easy it would be to automate this process.

> > No matching package to install: 'python3dist(ipuz)'
> 
> The python-ipuz package was reviewed in RHBZ 2138047 and is now in
> testing repositories. But I think we should wait until it gets to
> stable and we can successfully build this package.
> 
> Is that okay with you?

Yup, that's totally fine. Thanks!


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2138486
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux