[Bug 2139183] Review Request: coffeescript - A programming language that transcompiles to JavaScript - core compiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2139183



--- Comment #3 from Stephen Gallagher <sgallagh@xxxxxxxxxx> ---
(In reply to Vít Ondruch from comment #2)
> I'd be more then happy if this replaced the coffee-script package (and me
> not being maintainer of CoffeeScript). Unfortunately, there is
> rubygem-coffee-script-source which still depends on coffee-script 1.x and in
> turn, there is the following dependency tree:


Good point, I should probably prep patches for those as well in a COPR before I
land this in F38.

...

> And several notes about the .spec (although I don't think I am the right
> person to review):
> 
> 1) Why is the dependency direction between coffeescript and js-coffeescript
> packages reversed? I believe that the main package is superset to the js-
> subpackage.

Mostly it just required less post-processing in %install, but I can put it back
the other direction if preferred.

> 2) Does `%autosetup` support `-a 2` option to replace the `tar xf %{SOURCE2}`

Thanks, I was unaware of that option. I'll change it.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2139183
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux