https://bugzilla.redhat.com/show_bug.cgi?id=2051643 Jan Drögehoff <sentrycraft123@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(sentrycraft123@gm | |ail.com) | --- Comment #20 from Jan Drögehoff <sentrycraft123@xxxxxxxxx> --- (In reply to Alessio from comment #19) > Thank you @sentrycraft123@xxxxxxxxx > > New spec and srpm > > Spec URL: https://alciregi.fedorapeople.org/lite-xl/lite-xl.spec > SRPM URL: > https://alciregi.fedorapeople.org/lite-xl/lite-xl-2.1.0-1.fc37.src.rpm Haven't ran this this through fedora-review but I have one improvement to suggestion and one question: - lua, freetype2, pcre2 and sdl2 dependencies should be expressed using Pkgconfig Build Dependencies since that is what meson consumes. [1] - is the `--buildtype=release` intentional? %meson already sets all required flags and sets the buildtype to plain so that meson does not attempt to override any of them. [2] [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/ [2] https://mesonbuild.com/Quick-guide.html#using-meson-as-a-distro-packager -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2051643 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
