https://bugzilla.redhat.com/show_bug.cgi?id=2137117 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) Doc Type|--- |If docs needed, set a value Summary|New Package: arteFetcher |Review Request: artefetcher | |- Fetch videos from German | |and French Arte+7 website CC| |ppisar@xxxxxxxxxx --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- I corrected formalities of this review request. I'm not a sponsor, so I cannot do this review. Just a few remarks: You call "gzip" command from the spec file. Then you should add a build-time dependency "BuildRequires: gzip". The same goes for "install command: "BuildRequires: coreutils". Also for "desktop-file-install": "BuildRequires: desktop-file-utils". "%make_build" macro means "BuildRequires: make". I guess the software is written in C++, so you need a C++ compiler: "BuildRequires: gcc-c++" Then the License tag should you a new SPDX format "GPL-3.0-or-later" <https://docs.fedoraproject.org/en-US/legal/license-field/>. See this table <https://docs.fedoraproject.org/en-US/legal/allowed-licenses/>. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2137117 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
