[Bug 2120132] Review Request: libglibutil - Provides glib utility functions and macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2120132



--- Comment #7 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> ---
Thank you for the changes.

> I'm not sure what to write honestly, i just know this package is a
> dependency of libgbinder which is more interesting. 

I understand, I was looking at the repo and I have no idea as well. I
just hoped you gathered some information from using it :-)

Looking at the debian package within the repo, they don't provide any
more information either. Okay, let's not block the review by this.

What do you think about creating an upstream issue and asking them to
provide a little bit more information about the project in the
README? You can link them this ticket and say that we both had no idea
how to describe the project :D

It's just a suggestion, if you decide not to do it, it's fine. If yes,
please add the link to the upstream issue like this

    # https://github.com/sailfishos/libglibutil/issues/XX
    %description
    Provides glib utility functions and macros


> Issues:
> =======
> - ldconfig not called in %post and %postun for Fedora 28 and later.
>   Note: /sbin/ldconfig called in libglibutil
>   See: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets

So it seems the

    %post -p /sbin/ldconfig
    %postun -p /sbin/ldconfig

lines should be removed, and I would guess these as well

    Requires(post): /sbin/ldconfig
    Requires(postun): /sbin/ldconfig


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2120132
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux