https://bugzilla.redhat.com/show_bug.cgi?id=2120131 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |fedora@xxxxxxxxxx --- Comment #3 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > %package devel > Requires: %{name} = %{version} 1. This should be an arch-specific dependency. 2. Please include the release number as well. In other words - "%{name}%{?_isa} = %{version}-%{release}" https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package > %build > %{set_build_flags} Calling %set_build_flags manually is no longer needed since Fedora 36. https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck > %install > rm -rf %{buildroot} Don't. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections > %files devel > %{_includedir}/gbinder/*.h This will make the package own the .h files, but not the directory. It should be ok to replace this with just "%{_includedir}/gbinder". Alternatively, you can add "%dir %{_includedir}/gbinder". https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/#_common_mistakes -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2120131 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
