Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request CppAD - A Package for Differentiation of C++ Algorithms https://bugzilla.redhat.com/show_bug.cgi?id=416761 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-12-19 10:54 EST ------- Well, * First of all, would you remove all seemingly-unneeded comments? They make your spec file less easy to read. * Please consider to use %?_dist tag. http://fedoraproject.org/wiki/Packaging/DistTag * For SourceURL, I recommend to %{version} (also %{name}) tag so that you won't have to modify the SourceURL when version is upgraded. * Why are the Summaries of (fake) main, -devel, -doc are all same? * rm -rf $RPM_BUILD_ROOT is not needed for %prep * If some tests are executable, the move them to %check section and remove %{_validation_testing_during_rpmbuild} related description. * support parallel make if possible. * Please use macros. http://fedoraproject.org/wiki/Packaging/RPMMacros - For example, /usr must be %_prefix. - And please use %configure if possible (please check what %configure actually does by $ rpm --eval %configure ) * On %install if ! make install DESTDIR=$RPM_BUILD_ROOT then echo "Error during make install DESTDIR=$RPM_BUILD_ROOT" exit 1 fi "exit 1" is not neede as rpmbuild executes shell script with "set -e" (i.e. if error occurs, the execution of shell script fails) * If this package does not create any debuginfo information, please refer to the section "Useless or incomplete debuginfo packages due to packaging issues" of http://fedoraproject.org/wiki/Packaging/Debuginfo -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review