https://bugzilla.redhat.com/show_bug.cgi?id=2138899 --- Comment #4 from Sandro <gui1ty@xxxxxxxxxxxxx> --- > So, this is now a case where the pyproject macros don't pick up the LICENSE > file---perhaps because it's not marked as such in the python setup metadata. > So, we need to manually add the line. > > $ rpm -ql --licensefiles -p > ./results_python-dunamai/1.13.2/2.fc38/python3-dunamai-1.13.2-2.fc38.noarch. > rpm > /usr/share/licenses/python3-dunamai/LICENSE > > I do the build without the extra %license line first, then check to see if > the license is included by the pyproject macros. If not, then I add an extra > %license line. That sounds like a hit and miss. Not my preferred approach, although not always avoidable. Looking at the project, I would actually expect the LICENSE file to be picked up and marked as such. It's a standard name in a standard location, so it should be correctly detected according to some PEP. Might be worth reporting this as a bug for pyproject-rpm-macros since you seem to rely on licenses being detected correctly. But I guess I stick with my explicit and transparent %license macro. If that duplicates the license file, so be it. Last but not least, since the LICENSE file is installed you could mark that instead: '%license %{python3_sitelib}/%{name}-%{version}.dist-info/LICENSE'. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2138899 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
