https://bugzilla.redhat.com/show_bug.cgi?id=2120132 Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jkadlcik@xxxxxxxxxx --- Comment #4 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Hello Alessandro, thank you for the package. Overall it looks good to me. > Source: %{url}/archive/refs/tags/%{version}.tar.gz Sources should be indexed, starting from zero. Can you please change it to Source0? > %description > Provides glib utility functions and macros Can you please write 2-3 full sentences about the package? > rm -rf %{buildroot} This can IMHO be removed > %defattr(-,root,root,-) I believe this isn't needed as well. Did you have to add it to address some issue? > %post -p /sbin/ldconfig > %postun -p /sbin/ldconfig Note to myself to look at these again, running out of time now :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2120132 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
