https://bugzilla.redhat.com/show_bug.cgi?id=2138378 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |rjones@xxxxxxxxxx Flags|needinfo?(decathorpe@gmail. | |com) | --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Yup, they go through the normal review process, the review is just often really simple - because most of the packaging files can be automatically generated. For example, here's a review I recently did: https://bugzilla.redhat.com/show_bug.cgi?id=2118891#c4 Things that are interesting to the review process are usually: - Is the license acceptable and are all necessary license files included (i.e. MIT or Apache-2.0 require license files)? - Does it build *and* install without errors (especially off-by-default feature subpackages)? - If running the test suite or individual tests are disabled, is the reason for that documented? - If there are any downstream patches, are the reasons for them documented? - Have PRs been filed for "upstreamable" patches? So, basically, there need to be justifications for any manual edits to the automatically generated spec. (If there's something the packager needs to fix in the automatically generated spec *because the generated spec is wrong*, then we consider that a bug in rust2rpm that should be filed there, so it can be fixed for *all packages*.) Hope that makes sense, and thanks for the review! I've been interested in packaging the io-uring support for a while, this has finally pushed me to work on it again, and it turns out, the crate now works on all architectures. :) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2138378 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
