https://bugzilla.redhat.com/show_bug.cgi?id=2130607 --- Comment #40 from Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> --- (In reply to Sébastien Le Roux from comment #38) > Hello, > Alex polishing things up, I remove the '--prefix=/usr' in the spec file > which I think should not be there, As long as your build automation does things The Right Way™ and all the files get installed where they should be, it doesn't matter. (In reply to Sergey from comment #39) > (In reply to Sébastien Le Roux from comment #38) > -make `%{?_smp_mflags}` > +make %{?_smp_mflags} Good eye Sergey. Where those backticks always there? There is an issue with your changelog though, you need to trim it down. The one maintained in the rpm package, should not be the same as the one you maintain upstream (and which you can install with the %doc macro in your %files section). It should contain information about changes made to the package, spec file, perhaps important bugs fixed, etc.. The scope is different than the changes you document upstream. In this case, end users reading it might care for example about configuration file changes, or some shortcut being placed in a specific folder. A co-maintainer or a packager coordinating a rebuild or migration would care about any patches you might have included, changes with regard to dependencies and things like that. See these two sections: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs When you have finished with that, go pass your unsolicited judgement on other people's review requests, so that you may get sponsored. Feel free to cc me in any bugs you comment on. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2130607 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
