https://bugzilla.redhat.com/show_bug.cgi?id=1992629 Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jkadlcik@xxxxxxxxxx --- Comment #2 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Hello Hirotaka, thank you for the package. > Version: 4.3.0 I am not familiar with launchpad.net and I am not sure how to find what is the latest official release but the tarballs here https://tarballs.opendev.org/openstack/oslo.messaging/ go as high as 14.0.0 Should we rather package a higher version? > URL: https://launchpad.net/oslo I think a better URL would be https://launchpad.net/oslo.messaging > %global common_desc2 \ > Tests for the Oslo Middleware library. We can keep this if you prefer but the variable name is non-descriptive and it is used only once. I would simply do %description -n python3-%{pkg_name}-tests Tests for the Oslo Middleware library. and drop the variable. > # License file for jslibs using in -doc subpkg > Source1: LICENSE_doc In the package review template, we have the two following checks [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Package does not include license text files separate from upstream. If the package documentation is indeed available under a different license, can you please ask upstream to add its license file so we don't have to do it in Source1? Also, the LICENSE_doc file isn't present in the SRPM file, so I am not really sure where it comes from $ rpm -qpl python-oslo-middleware-4.3.0-1.src.rpm 0x4c29ff0e437f3351fd82bdf47c5a3bc787dc7035.txt oslo.middleware-4.3.0.tar.gz oslo.middleware-4.3.0.tar.gz.asc python-oslo-middleware.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1992629 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
