https://bugzilla.redhat.com/show_bug.cgi?id=2137152 --- Comment #1 from fedepell <fede@xxxxxxxxxxxx> --- First minor/major comment: saw that just today version 0.10.0 was released including your patch (that is in the SRPM): maybe worth bumping directly to that? > Source: %{url}/archive/v%{version}/v%{version}.tar.gz > # Remove shebang from a file that is not intended to be executed > Patch: https://github.com/xattr/xattr/pull/106.patch Can use %{url} also for patch? > BuildRequires: gcc > BuildRequires: pytest > BuildRequires: python3-devel Usually I see it's norm to put a comment before the testing ones (just pytest in this case) > %doc CHANGES.txt > %doc README.rst Could put all in a line? Maybe add as well TODO.txt Maybe add also "%license LICENSE.txt" ? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2137152 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
