https://bugzilla.redhat.com/show_bug.cgi?id=2126348 --- Comment #4 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > BuildRequires > FIX: Please add build-requires: <...> Almost all missing dependencies were added only one is missing. FIX: Add BR - perl(Config) - spec file:54 > FIX: Please add run-requires: > perl(XSLoader) - lib/Tickit.pm:19 +# Runtime +Requires: perl(XSLoader) Ok. > $ rpm -qp --requires perl-Tickit-tests-0.73-1.fc38.x86_64.rpm | sort | uniq -c | grep -v rpmlib <...> > FIX: Please remove duplicated run-require 'perl(Test::Fatal)' -Requires: perl(Test::Fatal) Ok > FIX: Please add run-requires 'perl(constant)' Still need to be fixed > FIX: In section %files, > - please move LICENSE from %docs to %license > - please remove META.json, it is only metadata - not useful -%doc Changes examples LICENSE META.json README +%doc Changes examples README +%license LICENSE Ok. > FIX: The t/99pod.t has to be removed from perl-Tickit-tests. Test::Pod check > works only for lib/ in the repository. +rm %{buildroot}%{_libexecdir}/%{name}/t/99pod.t Ok. Please correct all 'FIX' items and provide a new spec file. Resolution: NOT Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2126348 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
