[Bug 2135713] Review Request: python-tpm2-pytss - TPM 2.0 TSS Bindings for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2135713



--- Comment #6 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
Is it possible to do?

  %py3_check_import %{_name} -> %pyproject_check_import

It's simpler and it also imports all "public" submodules.



About the BuildRequuires:

The following runtime requirements are now generated by
%pyproject_buildrequires and MUST not be repeated manually:

BuildRequires:  python3-asn1crypto
BuildRequires:  python3-cffi >= 1
BuildRequires:  python3-cryptography


The following build requirements are now generated by %pyproject_buildrequires
and MUST not be repeated manually:

BuildRequires:  python3-pkgconfig
BuildRequires:  python3-setuptools_scm
BuildRequires:  python3-wheel
BuildRequires:  python3-pip
BuildRequires:  python3-setuptools
BuildRequires:  python3-setuptools_scm+toml


The following BuildRequires seem like they are needed to build the docs, which
you don't (and I don't recommend doing it anyway), so they are most likely
redundant:

BuildRequires:  python3-docutils
BuildRequires:  python3-myst-parser
BuildRequires:  python3-sphinx


The following BuildRequires seem odd, why are they needed?:

BuildRequires:  python3-build


The following BuildRequires are justified for tests but are definitively not
needed unless you use %tox, which you don't:

BuildRequires:  python3-tox-current-env

And if you want to use %tox, add -t to %pyproject_buildrequires instead,
please.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2135713
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux