Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: netbsd-iscsi - User-space implementation of iSCSI target from NetBSD project Alias: netbsd-iscsi-review https://bugzilla.redhat.com/show_bug.cgi?id=415791 mmahut@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From mmahut@xxxxxxxxxx 2007-12-18 15:23 EST ------- + Package is named according to the Package Naming Guidelines. + Spec file name must match the base package %{name}, in the format %{name}.spec. + Package meets the Packaging Guidelines. + Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: Fedora rawhide + Rpmlint output is sane. + Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) + Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. + License field in the package spec file matches the actual license. License type: BSD + Spec file is legible and written in American English. + Package is not known to require ExcludeArch + Package must own all directories that it creates. + Package does not contain duplicates in %files. + Permissions on files are set properly. + Package has a %clean section, which contains rm -rf of the buildroot + Package consistently uses macros. + File based requires are sane. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review