https://bugzilla.redhat.com/show_bug.cgi?id=2130026 --- Comment #8 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Sandro Mani from comment #6) > Full review below: > > Some minor issues: > [!]: License file installed when any subpackage combination is installed. > > => Add the licenses also to %doc, or have it require the main package I chose the latter. I think that's the preferred approach. > [!]: If the package is under multiple licenses, the licensing breakdown > must be documented in the spec. > => Document breakdown Added some comments in the specfile. Public License appears to have been abandoned. I removed it. > [!]: Spec use %global instead of %define unless justified. > Note: %define requiring justification: %define autorelease(e:s:pb:n) > %{?-p:0.}%{lua: > => Not sure whether %global can be used here, in case add a justification > comment for %define That's the result of using autospec. Cannot be avoided. > Other comments (no action needed as far as I'm concerned): > - At your option, could use %{buildroot} rather than ${RPM_BUILD_ROOT} > - Multiple warnings emitted when building documentation due to various > inventory not available (would require network access): > - https://docs.python.org/3/objects.inv... > - https://matplotlib.org/stable/objects.inv... > - https://numpy.org/doc/stable/objects.inv... > - https://docs.scipy.org/doc/scipy/objects.inv... > => Documentation likely has broken links Yeah. I haven't actually checked the contents of the documentation. :( > Approved, but please address the first three issues before importing. Thanks. Could you have a last glance at the current specfile. Just to make sure, I didn't do anything stupid. Spec URL: https://download.copr.fedorainfracloud.org/results/gui1ty/neuro-sig/fedora-rawhide-x86_64/04964356-python-mizani/python-mizani.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/gui1ty/neuro-sig/fedora-rawhide-x86_64/04964356-python-mizani/python-mizani-0.8.1-2.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2130026 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
