https://bugzilla.redhat.com/show_bug.cgi?id=2119494 --- Comment #22 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Comments: a) Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages The unversioned .so files should be in the devel package. These typically softlink to versioned .so files in the main package. b) Is it possible to apply patches to a recent snapshot from https://sourceforge.net/projects/aubit4gl/ and then build from this? For example one could download https://sourceforge.net/code-snapshots/svn/a/au/aubit4gl/aubit4gl_code/aubit4gl-aubit4gl_code-r12788.zip c) Can you try to get your changes incorporated in the upstream source? This will make it easier for other projects that wish to use aubit4gl within Fedora. d) Code builds but not on s390x https://copr.fedorainfracloud.org/coprs/fed500/aubit4gl-review/build/4958117/ s390x is not essential though. e) The archive aubit4gl-20221019.r12787.tar.bz2 contains many files in the .svn directory. If getting a specific snapshot, these are not needed. The archive: https://sourceforge.net/code-snapshots/svn/a/au/aubit4gl/aubit4gl_code/aubit4gl-aubit4gl_code-r12788.zip does not contain .svn files, and also has the sources for the tests and documentation. f) Parallel make probably fails because dependencies may not be built in the correct order. Having a Makefile.in and letting autotools generate the makefile would likely enable parallel make to be used. Asked on their mailing list about updating the makefiles. g) There is support for GUIs and databases. Should these be enabled? Possibly as subpackages? h) Could you work with upstream to update this: https://sourceforge.net/p/aubit4gl/aubit4gl_code/HEAD/tree/aubit4glsrc/trunk/etc/aubit-rpm.spec.in it may make package maintenance easier. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2119494 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
