[Bug 2130607] Review Request: Atomes - An atomistic tool box

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2130607



--- Comment #26 from Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> ---
(In reply to Sébastien Le Roux from comment #25)
> I think that 'desktop-file-utils' and 'libappstream-glib' are required at
> install time, that's when the 'install-data-local' commands from
> 'Makefile.am' are processed, 
> that's why I think I have no choice but to check for this packages. 

Ok, so they are used only when the package is being created, therefore they are
not needed at runtime, ergo they should be removed.
Looking at your deps for the "rpm Fusion" package, I have a suspicion that
there's a misunderstanding someplace. Everything required to compile the
program and create the rpms (so everything that happens in %prep, %build,
%install and %check) is listed as "BuildRequires". Everything else that the
program might need when it is being used is listed as "Requires". Is this
clear?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2130607
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux