https://bugzilla.redhat.com/show_bug.cgi?id=2130607 --- Comment #24 from Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> --- Hi Sébastien, well done. Here's what's left: - desktop-file-utils and libappstream-glib should be required only at build time, did you have any reason to add them as run time deps? If not, remove them. - The screenshots that are included in the AppStream file are not 16:9 and one of them has padding - this is what you see if you run appstream-util validate-strict: • aspect-ratio-invalid : <screenshot> aspect ratio not 16:9 [https://atomes.ipcms.fr/wp-content/uploads/2022/08/Ni-Phth-1024x512.jpeg] • style-invalid : <image> has vertical padding [https://atomes.ipcms.fr/wp-content/uploads/2022/08/lGeSe-1024x625.png] • aspect-ratio-invalid : <screenshot> aspect ratio not 16:9 [https://atomes.ipcms.fr/wp-content/uploads/2022/08/lGeSe-1024x625.png] • aspect-ratio-invalid : <screenshot> aspect ratio not 16:9 [https://atomes.ipcms.fr/wp-content/uploads/2022/08/workm2-1024x647.png] While the other warnings from appstream-util in strict mode can be ignored, I think that GNOME Software (and all the other software-center-type installers built on the same base) will throw a tantrum. See here for examples of good and bad screenshots: https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html#qsr-app-screenshots-info In GNOME, you can use the screenshot window sizer extension to easily get 16:9 application windows: https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html#qsr-app-screenshots-info Remember that if you want, you can also caption your images in the XML file, e.g.: <screenshot type="default"> <caption>Distance measurements on a Ni phthalocyanine unit cell</caption> <image>https://atomes.ipcms.fr/wp-content/uploads/2022/08/Ni-Phth-1024x512.jpeg</image> </screenshot> -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2130607 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
